On Mar 1, 2012, at 5:00 PM, Chuck Lever wrote:
> Get rid of
>
> encode_compound: tag=
>
> when XDR debugging is enabled. The current Linux client never sets
> compound tags.
>
> Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
> ---
>
> fs/nfs/nfs4xdr.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfs/nfs4xdr.c b/fs/nfs/nfs4xdr.c
> index 4ca87cb..d1b7914d 100644
> --- a/fs/nfs/nfs4xdr.c
> +++ b/fs/nfs/nfs4xdr.c
> @@ -889,7 +889,9 @@ static void encode_compound_hdr(struct xdr_stream *xdr,
> * but this is not required as a MUST for the server to do so. */
> hdr->replen = RPC_REPHDRSIZE + auth->au_rslack + 3 + hdr->taglen;
>
> +#if 0
> dprintk("encode_compound: tag=%.*s\n", (int)hdr->taglen, hdr->tag);
> +#endif
We probably don't want to #if 0 this out. Either remove the line, or do something like:
if (hdr->taglen > 0)
dprintk(…);
This way, if we ever do have a tag set, it'll be displayed.
Thanks for suggesting this -- getting rid of useless dprintk output is a good thing!
-dros
> BUG_ON(hdr->taglen > NFS4_MAXTAGLEN);
> p = reserve_space(xdr, 4 + hdr->taglen + 8);
> p = xdr_encode_opaque(p, hdr->tag, hdr->taglen);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
