From: "J. Bruce Fields" <bfields@xxxxxxxxxx>
Yes, 5661 does say to return NOTDIR in this case. But I can't figure
out why. Elsewhere it's generally preferred to return the more specific
SYMLINK error. This is a buggy-client case (since the source and target
dirs are referred to by filehandle, the client should generally know
whether it's dealing with a directory or not), so I don't see the point
of being really picky here.
Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
---
nfs4.1/server41tests/st_rename.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/nfs4.1/server41tests/st_rename.py b/nfs4.1/server41tests/st_rename.py
index f706a1c..cde8ffc 100644
--- a/nfs4.1/server41tests/st_rename.py
+++ b/nfs4.1/server41tests/st_rename.py
@@ -201,7 +201,8 @@ def testCfhLink(t, env):
res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.uselink + [name])
- check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
+ checklist(res, [NFS4ERR_NOTDIR, NFS4ERR_SYMLINK],
+ "RENAME with non-dir <cfh>")
def testCfhBlock(t, env):
"""RENAME with non-dir (cfh) should return NFS4ERR_NOTDIR
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
