Re: [patch] svcrdma: silence a Sparse warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
> 
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.

Thanks, applying.--b.

> 
> Tom
> 
> 
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<dan.carpenter@xxxxxxxxxx>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >>  extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >>  extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >>  extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>-					    u32, u64, u32);
> >>+					    __be32, __be64, u32);
> >>  extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >>  					     struct rpcrdma_msg *,
> >>  					     struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to majordomo@xxxxxxxxxxxxxxx
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux