Re: [PATCH 02/13] NFS: Fix comparison signage warnings with slot ID computations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 16, 2012, at 2:52 PM, Myklebust, Trond wrote:

> On Wed, 2012-02-15 at 16:35 -0500, Chuck Lever wrote:
>> To make nfs4proc.c compile cleanly, address the following compiler
>> warnings:
>> 
>> fs/nfs/nfs4proc.c: In function ‘nfs4_free_slot’:
>> fs/nfs/nfs4proc.c:371:2: warning: comparison between signed and
>> 		unsigned integer expressions [-Wsign-compare]
>> fs/nfs/nfs4proc.c: In function ‘nfs4_reset_slot_table’:
>> fs/nfs/nfs4proc.c:5000:15: warning: comparison between signed and
>> 		unsigned integer expressions [-Wsign-compare]
>> fs/nfs/nfs4proc.c: In function ‘nfs4_init_slot_table’:
>> fs/nfs/nfs4proc.c:5064:2: warning: comparison between signed and
>> 		unsigned integer expressions [-Wsign-compare]
>> 
>> Why is max_reqs always u32, but nfs4_slot_table.max_slots a signed
>> integer?
>> 
> 
> There is already a fix for this in the nfs-for-next branch.

I'll drop mine.

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux