On Feb 13, 2012, at 6:08 PM, Andy Adamson wrote:
> On Mon, Feb 13, 2012 at 6:01 PM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote:
>> Hi-
>>
>> On Feb 13, 2012, at 4:54 AM, andros@xxxxxxxxxx wrote:
>>
>>> From: Andy Adamson <andros@xxxxxxxxxx>
>>>
>>> With static RPC slots, the xprt backlog queue stats were useful in showing
>>> when the transport (TCP) was starved by lack of RPC slots. The new dynamic
>>> RPC slot code, commit d9ba131d8f58c0d2ff5029e7002ab43f913b36f9, always
>>> provides an RPC slot and so only uses the xprt backlog queue when the
>>> tcp_max_slot_table_entries value has been hit or when an allocation error
>>> occurs. All requests are now placed on the xprt sending or pending queue which
>>> need to be monitored for debugging.
>>>
>>> The max_slot stat shows the maximum number of dynamic RPC slots reached which is
>>> useful when debugging performance issues.
>>>
>>> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
>>
>> OK, now I'm really confused. The e-mail address says "W Andros Adamson" -- I thought that this is the son, Weston Andros Adamson, not the father. But the sign-off is from andros@xxxxxxxxxx. Help?
>
> I don't see "W Andros Adamson" anywhere - but that is my name! I'm
> William Andros Adamson, Dros is Weston Andros Adamson which makes us
> both W. Andros Adamson.
Just to confuse everyone :)
For the purposes of this list he is Andy (andros@) and I am Dros (dros@). It's not wrong when you call me Andy or Andros - it's just confusing!
>
> heh heh.
>
^^ Blame no one but yourself! I guess you can blame Mom too...
-dros
>
>>
>> More below.
>>
>>> ---
>>> include/linux/sunrpc/xprt.h | 7 +++++--
>>> net/sunrpc/xprt.c | 7 ++++++-
>>> net/sunrpc/xprtsock.c | 25 ++++++++++++++++++-------
>>> 3 files changed, 29 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h
>>> index 15518a1..344b6f2 100644
>>> --- a/include/linux/sunrpc/xprt.h
>>> +++ b/include/linux/sunrpc/xprt.h
>>> @@ -219,10 +219,13 @@ struct rpc_xprt {
>>> connect_time, /* jiffies waiting for connect */
>>> sends, /* how many complete requests */
>>> recvs, /* how many complete requests */
>>> - bad_xids; /* lookup_rqst didn't find XID */
>>> + bad_xids, /* lookup_rqst didn't find XID */
>>> + max_slots; /* max rpc_slots used */
>>>
>>> unsigned long long req_u, /* average requests on the wire */
>>> - bklog_u; /* backlog queue utilization */
>>> + bklog_u, /* backlog queue utilization */
>>> + sending_u, /* send q utilization */
>>> + pending_u; /* pend q utilization */
>>> } stat;
>>>
>>> struct net *xprt_net;
>>> diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c
>>> index c64c0ef..fb95e25 100644
>>> --- a/net/sunrpc/xprt.c
>>> +++ b/net/sunrpc/xprt.c
>>> @@ -884,7 +884,7 @@ void xprt_transmit(struct rpc_task *task)
>>> {
>>> struct rpc_rqst *req = task->tk_rqstp;
>>> struct rpc_xprt *xprt = req->rq_xprt;
>>> - int status;
>>> + int status, numreqs;
>>>
>>> dprintk("RPC: %5u xprt_transmit(%u)\n", task->tk_pid, req->rq_slen);
>>>
>>> @@ -921,9 +921,14 @@ void xprt_transmit(struct rpc_task *task)
>>>
>>> xprt->ops->set_retrans_timeout(task);
>>>
>>> + numreqs = atomic_read(&xprt->num_reqs);
>>> + if (numreqs > xprt->stat.max_slots)
>>> + xprt->stat.max_slots = numreqs;
>>> xprt->stat.sends++;
>>> xprt->stat.req_u += xprt->stat.sends - xprt->stat.recvs;
>>> xprt->stat.bklog_u += xprt->backlog.qlen;
>>> + xprt->stat.sending_u += xprt->sending.qlen;
>>> + xprt->stat.pending_u += xprt->pending.qlen;
>>>
>>> /* Don't race with disconnect */
>>> if (!xprt_connected(xprt))
>>> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
>>> index 55472c4..2a80817 100644
>>> --- a/net/sunrpc/xprtsock.c
>>> +++ b/net/sunrpc/xprtsock.c
>>> @@ -2226,8 +2226,8 @@ static void xs_local_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>>> if (xprt_connected(xprt))
>>> idle_time = (long)(jiffies - xprt->last_used) / HZ;
>>>
>>> - seq_printf(seq, "\txprt:\tlocal %lu %lu %lu %ld %lu %lu %lu "
>>> - "%llu %llu\n",
>>> + seq_printf(seq, "\txprt:\tlocal %lu %lu %lu %ld %lu %lu %lu %lu "
>>> + "%llu %llu %llu %llu\n",
>>> xprt->stat.bind_count,
>>> xprt->stat.connect_count,
>>> xprt->stat.connect_time,
>>> @@ -2235,8 +2235,11 @@ static void xs_local_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>>> xprt->stat.sends,
>>> xprt->stat.recvs,
>>> xprt->stat.bad_xids,
>>> + xprt->stat.max_slots,
>>> xprt->stat.req_u,
>>> - xprt->stat.bklog_u);
>>> + xprt->stat.bklog_u,
>>> + xprt->stat.sending_u,
>>> + xprt->stat.pending_u);
>>> }
>>>
>>> /**
>>
>> This hunk changes the format and content of /proc/self/mountstats. I don't see where you are bumping the statvers so mountstats can tell what is going on. Since you are adding fields, mountstats may not complain about this, but it will probably display incorrect output since you are adding a field somewhere in the middle of the line.
>
> Noted: I'll add a bump to the statvers.
>
> -->Andy
>
>>
>>> @@ -2249,14 +2252,18 @@ static void xs_udp_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>>> {
>>> struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt);
>>>
>>> - seq_printf(seq, "\txprt:\tudp %u %lu %lu %lu %lu %Lu %Lu\n",
>>> + seq_printf(seq, "\txprt:\tudp %u %lu %lu %lu %lu %lu %llu %llu "
>>> + "%llu %llu\n",
>>> transport->srcport,
>>> xprt->stat.bind_count,
>>> xprt->stat.sends,
>>> xprt->stat.recvs,
>>> xprt->stat.bad_xids,
>>> + xprt->stat.max_slots,
>>> xprt->stat.req_u,
>>> - xprt->stat.bklog_u);
>>> + xprt->stat.bklog_u,
>>> + xprt->stat.sending_u,
>>> + xprt->stat.pending_u);
>>> }
>>>
>>> /**
>>
>> Likewise.
>>
>>> @@ -2273,7 +2280,8 @@ static void xs_tcp_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>>> if (xprt_connected(xprt))
>>> idle_time = (long)(jiffies - xprt->last_used) / HZ;
>>>
>>> - seq_printf(seq, "\txprt:\ttcp %u %lu %lu %lu %ld %lu %lu %lu %Lu %Lu\n",
>>> + seq_printf(seq, "\txprt:\ttcp %u %lu %lu %lu %ld %lu %lu %lu %lu "
>>> + "%llu %llu %llu %llu\n",
>>> transport->srcport,
>>> xprt->stat.bind_count,
>>> xprt->stat.connect_count,
>>> @@ -2282,8 +2290,11 @@ static void xs_tcp_print_stats(struct rpc_xprt *xprt, struct seq_file *seq)
>>> xprt->stat.sends,
>>> xprt->stat.recvs,
>>> xprt->stat.bad_xids,
>>> + xprt->stat.max_slots,
>>> xprt->stat.req_u,
>>> - xprt->stat.bklog_u);
>>> + xprt->stat.bklog_u,
>>> + xprt->stat.sending_u,
>>> + xprt->stat.pending_u);
>>> }
>>>
>>> /*
>>
>> And here too.
>>
>> --
>> Chuck Lever
>> chuck[dot]lever[at]oracle[dot]com
>>
>>
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
