On Tue, 2012-01-31 at 16:54 +0200, Boaz Harrosh wrote: > On 01/31/2012 01:57 AM, Jeff Layton wrote: > > WARNING: at lib/debugobjects.c:262 debug_print_object+0x8c/0xb0() > > > > For now, this patch is really just papering over that problem, but it > > should be "mostly harmless". That said, I'm ok with dropping it if > > Thomas is planning to fix this in the debugobjects code however. > > > > I disagree it's harmless. What if kmem_cache_free/kmem_cache_alloc deploys > a poisoning schema, in debug mode. Which stumps over memory. Is it > initialized then? If that were the case, then the entire inode would be useless to us. We rely on initialisation in init_once() for a bunch of other stuff including list heads, waitqueue heads, etc. > What was the last state of the timer, is it safe for resume? Initialised, and yes. > For us this is a new object we should initialize it. No it is definitely not a new object... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥