On Sun, Jan 15, 2012 at 05:20:03PM +0100, Tigran Mkrtchyan wrote:
> +static void
> +put_stateid(struct nfsd4_compound_state *cstate, stateid_t *stateid)
> +{
> + if (cstate->minorversion)
> + cstate->current_stateid = stateid;
> +}
...
> @@ -54,6 +54,7 @@ struct nfsd4_compound_state {
> size_t iovlen;
> u32 minorversion;
> u32 status;
> + const stateid_t *current_stateid;
> };
I'd be more comfortable with passing stateid's by value rather than by
reference.
Presumably you're only ever pointing into one of the argument or result
structures which are currently guaranteed to be around for as long as
the compound is processed.
But it'd seem safer not to have to worry about the lifetime of the
pointed-to data at all, and just copy the stateid--it's only 16 bytes.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
