On Wed, 14 Dec 2011 10:09:04 -0500
Steve Dickson <SteveD@xxxxxxxxxx> wrote:
>
>
> On 12/14/2011 08:57 AM, Jeff Layton wrote:
> > Generally, we want this daemon started before nfsd starts. Deal with the
> > situation where the pipe hasn't shown up yet.
> This can be done with your systemd start up script. Plus I'm not sure its
> a good idea to steal cpu cycles waiting for an event that may never happen...
>
Presumably you just wouldn't start the daemon if you have no intent to
use it.
It does sleep 1s between each check, so the time is fairly minimal,
but I'm definitely open to doing this differently. What may be
reasonable is adding code to the daemon to check and see if the
v4recoverydir is present. If it is, then just exit. Otherwise, wait for
the pipe to show up.
>
> >
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> > ---
> > utils/clstated/clstated.c | 15 +++++++++++----
> > 1 files changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/utils/clstated/clstated.c b/utils/clstated/clstated.c
> > index 93a2710..aab09a7 100644
> > --- a/utils/clstated/clstated.c
> > +++ b/utils/clstated/clstated.c
> > @@ -75,10 +75,17 @@ usage(char *progname)
> > static int
> > clstate_pipe_open(struct clstate_client *clnt)
> > {
> > - clnt->cl_fd = open(pipepath, O_RDWR, 0);
> > - if (clnt->cl_fd < 0) {
> > - xlog(L_ERROR, "%s: unable to open %s: %m", __func__, pipepath);
> > - return clnt->cl_fd;
> > + /* loop until the pipe is present or open fails for another reason */
> > + for (;;) {
> > + clnt->cl_fd = open(pipepath, O_RDWR, 0);
> > + if (clnt->cl_fd >= 0) {
> > + break;
> > + } else if (errno != ENOENT) {
> > + xlog(D_GENERAL, "%s: unable to open %s: %m", __func__,
> > + pipepath);
> > + return clnt->cl_fd;
> > + }
> > + sleep(1);
> > }
> >
> > event_set(&clnt->cl_event, clnt->cl_fd, EV_READ, clstatecb, clnt);
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
