On Wed Dec 14 09:07:44 2011, J. Bruce Fields wrote: > On Wed, Dec 14, 2011 at 08:42:18AM -0500, Bryan Schumaker wrote: >> On Tue Dec 13 17:12:09 2011, J. Bruce Fields wrote: >>> On Tue, Dec 13, 2011 at 04:35:58PM -0500, bjschuma@xxxxxxxxxx wrote: >>>> From: Bryan Schumaker <bjschuma@xxxxxxxxxx> >>>> >>>> unhash_delegation() will grab the recall lock before calling >>>> list_del_init() in each of these places. This patch removes the >>>> redundant calls. >>> >>> Looks right, thanks. (How did you happen across this?) >> >> I was looking over the fault injection stuff to see if I can figure out >> where an occasional oops was coming from. It seems to happen when I >> forget delegations, so I was looking at how other functions release >> delegations to see if there was something I missed. The oops doesn't >> happen often enough for me to know if this patch fixes it yet, though. > > Hm, OK. Could you post the oops? I don't see it in the logs on the server, but I'll keep looking. I'll post it the next time I come across it. - Bryan > > --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
