On Mon, 12 Dec 2011, Andrew Morton wrote: > On Mon, 12 Dec 2011 18:45:11 -0500 > Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote: > > > On Mon, 2011-12-12 at 18:39 -0500, Trond Myklebust wrote: > > > > > As far as NFS is concerned, it reverts a regression. NFS only used to > > > run revalidate_file_size() for SEEK_END prior to commit > > > 06222e491e663dac939f04b125c9dc52126a75c4. I accept that we now also need > > > to run it for SEEK_HOLE and SEEK_DATA, but we've never had to do so for > > > SEEK_SET and SEEK_CUR. > > > > BTW: The regression exists in 3.1, so this is probably a stable > > candidate... > > > > I'd prefer not to merge this one unless all four fs maintainers have > reviewed and preferably tested it. Also, in view of your earlier email > the changelog for this patch needs updating for NFS and probably other > filesystems. > > So please prepare and send the NFS patch, with a Reported-by:roel? I'll push a fix for the ceph bit through my tree. Thanks, roel! sage -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html