On 2011-12-06 04:10, J. Bruce Fields wrote: > On Sun, Dec 04, 2011 at 03:48:16PM +0200, Benny Halevy wrote: >> From: Benny Halevy <bhalevy@xxxxxxxxxx> >> >> Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxx> >> --- >> fs/nfsd/bl_ops.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/nfsd/bl_ops.c b/fs/nfsd/bl_ops.c >> index 89249c4..4d2939e 100644 >> --- a/fs/nfsd/bl_ops.c >> +++ b/fs/nfsd/bl_ops.c >> @@ -57,7 +57,7 @@ >> #endif >> >> >> -typedef enum {True, False} boolean_t; >> +typedef enum {False = 0, True = !False} boolean_t; > > Shouldn't we just use "bool"? Yes, in some cases. In others, the boolean status doesn't make sense and I'd like to replace it with an integer. Benny > > --b. > >> /* ---- block layoutget and commit structure ---- */ >> typedef struct bl_layout_rec { >> struct list_head blr_hash, >> -- >> 1.7.6 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html