> -----Original Message----- > From: linux-nfs-owner@xxxxxxxxxxxxxxx [mailto:linux-nfs-owner@xxxxxxxxxxxxxxx] > On Behalf Of NeilBrown > Sent: Wednesday, November 16, 2011 8:47 AM > To: Trond Myklebust > Cc: NFS; Josef Bacik; Jan Kara; Al Viro > Subject: [PATCH] NFS - fix recent breakage to NFS error handling. > > From c6d615d2b97fe305cbf123a8751ced859dca1d5e Mon Sep 17 00:00:00 2001 > From: NeilBrown <neilb@xxxxxxx> > Date: Wed, 16 Nov 2011 09:39:05 +1100 > Subject: [PATCH] NFS - fix recent breakage to NFS error handling. > > commit 02c24a82187d5a628c68edfe71ae60dc135cd178 made a small and > presumably unintended change to write error handling in NFS. > > Previously an error from filemap_write_and_wait_range would only be of interest if > nfs_file_fsync did not return an error. After this commit, an error from > filemap_write_and_wait_range would mean that (the rest of) nfs_file_fsync would > not even be called. Do we need more consideration on commit 02c24a82187d5a628c68edfe71ae60dc135cd178? Before it, vfs_fsync_range() calls f_op->fsync() regardless of filemap_write_and_wait_range() errors. After commit 02c24a82187d5a628c68edfe71ae60dc135cd178, it only calls f_op->fsync() when filemap_write_end_and_wait_range() succeeds. So the change is not really trivial to all file systems. Thanks, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
