On 11/12/2011 02:15 PM, Jim Rees wrote:
> Steve Dickson wrote:
>
> + arg = malloc(sizeof(char) * strlen(argv[optind]) + 1);
> + strcpy(arg, argv[optind]);
>
> strdup() would have been simpler. But don't re-do it just for this.
We should also be checking for failure as well... Here's how I took care of it:
- arg = malloc(sizeof(char) * strlen(argv[2]) + 1);
- strcpy(arg, argv[2]);
+ if (verbose)
+ nfs4_set_debug(verbose, NULL);
+
+ key = strtol(argv[optind++], NULL, 10);
+
+ arg = strdup(argv[optind]);
+ if (arg == NULL) {
+ xlog_err("strdup failed: %m");
+ return 1;
+ }
steved.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
