On Mon, 2011-11-07 at 06:02 -0500, Christoph Hellwig wrote: > Does anyone have an explanation why nfs calls write_inode_now before > doing a sillrename? The comment above claims that we want to start > an asynchronous writeout, but given that NFS doesn't have dirty > inode metadata that needs to be written back from ->write_inode > this only starts data writeback. And that should be done using > filemap_fdatawrite or filemap_flush. filemap_fdatawrite() is never sufficient for writing out data, since it does nothing to ensure that the COMMIT gets sent: we have do that through the ->write_inode() callback. With pNFS there can also be the issue of sending the layoutcommit... Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
