On Fri 04 Nov 2011 05:42:54 PM EDT, J. Bruce Fields wrote: > On Tue, Nov 01, 2011 at 02:18:28PM -0400, bjschuma@xxxxxxxxxx wrote: >> From: Bryan Schumaker <bjschuma@xxxxxxxxxx> >> >> The close parenthesis was hard to find with it spaced so far over. > > What kind of terminal was Kendrick working with, anyway? > > If you don't mind the below as a friendly amendment, I'll queue it up > for 3.3. That looks like a good improvement to me. - Bryan > > --b. > > commit 70aec307e110a2a488e10323b4d2bbd89a3f6485 > Author: Bryan Schumaker <bjschuma@xxxxxxxxxx> > Date: Tue Nov 1 14:18:28 2011 -0400 > > NFSD: Remove unnecessary whitespace > > The close parenthesis was hard to find with it spaced so far over. > > Signed-off-by: Bryan Schumaker <bjschuma@xxxxxxxxxx> > [bfields@xxxxxxxxxx: get all these lines under 80 chars while we're here] > Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx> > > diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h > index 4e2ee29..1d1e858 100644 > --- a/fs/nfsd/nfsd.h > +++ b/fs/nfsd/nfsd.h > @@ -340,15 +340,15 @@ static inline u32 nfsd_suppattrs2(u32 minorversion) > } > > /* These will return ERR_INVAL if specified in GETATTR or READDIR. */ > -#define NFSD_WRITEONLY_ATTRS_WORD1 \ > -(FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET) > +#define NFSD_WRITEONLY_ATTRS_WORD1 \ > + (FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET) > > /* These are the only attrs allowed in CREATE/OPEN/SETATTR. */ > -#define NFSD_WRITEABLE_ATTRS_WORD0 \ > -(FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL ) > -#define NFSD_WRITEABLE_ATTRS_WORD1 \ > -(FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \ > - | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET) > +#define NFSD_WRITEABLE_ATTRS_WORD0 \ > + (FATTR4_WORD0_SIZE | FATTR4_WORD0_ACL) > +#define NFSD_WRITEABLE_ATTRS_WORD1 \ > + (FATTR4_WORD1_MODE | FATTR4_WORD1_OWNER | FATTR4_WORD1_OWNER_GROUP \ > + | FATTR4_WORD1_TIME_ACCESS_SET | FATTR4_WORD1_TIME_MODIFY_SET) > #define NFSD_WRITEABLE_ATTRS_WORD2 0 > > #define NFSD_SUPPATTR_EXCLCREAT_WORD0 \ -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
