> -----Original Message-----
> From: Adamson, Andy
> Sent: Tuesday, October 18, 2011 2:40 AM
> To: Myklebust, Trond
> Cc: linux-nfs@xxxxxxxxxxxxxxx; Adamson, Andy
> Subject: [PATCH (resend) Version 2 3/3] NFSv4.1: fix backchennel bug
>
> From: Andy Adamson <andros@xxxxxxxxxx>
>
> Slotid's start from 0 which means we check against
> NFS41_BC_MAX_CALLBACKS - 1.
>
> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> ---
> fs/nfs/callback_proc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c index
> 98ff5fc..12bd9d0 100644
> --- a/fs/nfs/callback_proc.c
> +++ b/fs/nfs/callback_proc.c
> @@ -339,7 +339,7 @@ validate_seqid(struct nfs4_slot_table *tbl, struct
> cb_sequenceargs * args)
> dprintk("%s enter. slotid %d seqid %d\n",
> __func__, args->csa_slotid, args->csa_sequenceid);
>
> - if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS)
> + if (args->csa_slotid > NFS41_BC_MAX_CALLBACKS - 1)
> return htonl(NFS4ERR_BADSLOT);
Why not just replace '>' with '>='?
Cheers
Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
