On Tue, 2011-11-01 at 00:16 +0600, Rakib Mullick wrote: > On Mon, Oct 31, 2011 at 11:43 PM, Trond Myklebust > <Trond.Myklebust@xxxxxxxxxx> wrote: > > On Mon, 2011-10-31 at 23:12 +0600, Rakib Mullick wrote: > >> On Mon, Oct 31, 2011 at 9:18 PM, Trond Myklebust > >> <Trond.Myklebust@xxxxxxxxxx> wrote: > >> > On Fri, 2011-10-28 at 16:36 +0600, Rakib Mullick wrote: > >> + data->inode->nfs_client->cl_hostname, > > ^^^^^^^^^^^^ > > NFS_SERVER(data->inode)->nfs_client.... > > Opss. Sorry, should've more careful, rather doing it quickly :(. > data->inode has nothing inside named nfs_client, but didn't even > complain. I'll resend it. > > Anyway, I found the two following warning in nfs/file.c > > fs/nfs/file.c: In function ‘nfs_file_release’: > fs/nfs/file.c:140:17: warning: unused variable ‘dentry’ > fs/nfs/file.c: In function ‘nfs_file_read’: > fs/nfs/file.c:237:9: warning: unused variable ‘count’ > > I'm wanting to send one patch to cleanup all these unused variable > issues. Shall I? Or, should I send separate patches? Please send 2 patches: the stuff in fs/nfs/file.c looks as if it predates the linux-3.1 release, and so we might want to keep those fixes in a separate patch. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
