On Sat, Oct 29, 2011 at 01:47:55PM -0400, Chuck Lever wrote: > > On Oct 29, 2011, at 6:16 AM, Christoph Hellwig wrote: > > > This function should probably grow a check for S_NOSEC instead of > > hitting the filesystems with an xattr read for every lookup. > > It doesn't perform the xattr read on _every_ lookup, but only when the object has a special set of permission bits. > > But actually, it probably doesn't need that 'type" attribute check at all. It should delegate that check to mountd. I assume many of those upcalls would hit in the export cache anyway? You're suggesting doing an upcall on every path that passes the mode-bit checks? You'd end up populating the export cache with every path that passes the mode-bit checks. I don't think that's a good idea. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
