On 10/28/2011 05:09 AM, Benny Halevy wrote:
>
> I agree with all of the above but its a project larger than I can
> chew right now. This patch just improves the existing mechanism, for
> development use, to help catch parser bugs rather than actual xdr errors.
>
<>
>>>
>>> +#define XDR_ERROR() do { \
>>> + dprintk("NFSD: xdr error (%s:%d)\n", \
>>> + __FILE__, __LINE__); \
>>> + goto xdr_error; \
>>> +} while (0)
>>> +
What about a compromise:
+#define GOTO_XDR_ERROR() do { \
+ dprintk("NFSD: xdr error (%s:%d)\n", \
+ __FILE__, __LINE__); \
+ goto xdr_error; \
+} while (0)
or even:
+#define XDR_ERROR_GOTO(xdr_error) do { \
+ dprintk("NFSD: xdr error (%s:%d)\n", \
+ __FILE__, __LINE__); \
+ goto xdr_error; \
+} while (0)
and XDR_ERROR_GOTO(xdr_error) every where.
So the patch below stays exactly the same size
but the goto is not masked out, and no one can
complain about things happening hidden underground.
Just My $0.017
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
