On Thu, Oct 20, 2011 at 12:22:41PM +0000, Benny Halevy wrote:
> The other patch was for the deny bits this is for the want mask...
> Similar bug, different place :)
Oog, sorry! OK, applying.
(And in fact I made the same ! for ~ mistake in one other place in the
last week that got caught by regression testing before I posted it. I
need to teach my editor to highlight !'s in blinking red, or
something....)
--b.
>
> Benny
> ------Original Message------
> From: J. Bruce Fields
> To: Benny Halevy
> Cc: J. Bruce Fields
> Cc: linux-nfs@xxxxxxxxxxxxxxx
> Cc: Benny Halevy
> Subject: Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
> Sent: Oct 20, 2011 04:53
>
> Yep, bad mistake on my part--but someone else already caught this, and
> it's already committed to my 3.2 branch.--b.
>
> On Wed, Oct 19, 2011 at 07:13:29PM -0700, Benny Halevy wrote:
> > From: Benny Halevy <bhalevy@xxxxxxxxxx>
> >
> > Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxx>
> > ---
> > fs/nfsd/nfs4xdr.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index 1a419c0..1a5cb7e 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> > @@ -671,7 +671,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
> > default:
> > return nfserr_bad_xdr;
> > }
> > - w &= !NFS4_SHARE_WANT_MASK;
> > + w &= ~NFS4_SHARE_WANT_MASK;
> > if (!w)
> > return nfs_ok;
> > switch (w) {
> > --
> > 1.7.6
> >
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
