On 10/15/2011 12:45 AM, Michal Marek wrote: > On 15.10.2011 00:27, Boaz Harrosh wrote: >> On 10/15/2011 12:03 AM, Michal Marek wrote: >>> On 14.10.2011 16:35, Boaz Harrosh wrote: >>>> This does not work. The ORE is not compiled and MODPOST complains. >>>> (Given EXOFS_FS is not selected since then it will work) >>> >>> fs/Makefile only visits fs/exofs if CONFIG_EXOFS_FS is set. >> >> Bingo. Right on the money. With below patch it works. I'll think >> about it some more and submit. >> >> Thanks >> --- >> exofs/ore: Select fs/exofs/ folder in Makefile also for ORE only compilation >> >> If any thing from fs/exofs is set the ORE will be selected. So conditionally >> include fs/exofs in fs/Makefile on ORE set and not EXOFS_FS > ... >> --- a/fs/Makefile >> +++ b/fs/Makefile >> @@ -120,6 +120,6 @@ obj-$(CONFIG_DEBUG_FS) += debugfs/ >> obj-$(CONFIG_OCFS2_FS) += ocfs2/ >> obj-$(CONFIG_BTRFS_FS) += btrfs/ >> obj-$(CONFIG_GFS2_FS) += gfs2/ >> -obj-$(CONFIG_EXOFS_FS) += exofs/ >> +obj-$(CONFIG_ORE) += exofs/ > > Note that changing it to obj-y is also valid. And perhaps more obvious. > > Michal Thanks. You read my thoughts. The naming would be off with my change. I'll take your advise and send a patch to Al on Monday. Cheers Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
