Boaz Harrosh wrote: On 09/23/2011 04:50 AM, Jim Rees wrote: > From: Peng Tao <bergwolf@xxxxxxxxx> > > pg_bsize is server->wsize/rsize by default. We would want to use the lseg > length. > > Signed-off-by: Peng Tao <peng_tao@xxxxxxx> > Signed-off-by: Jim Rees <rees@xxxxxxxxx> If you want to get lazy about this patch and take the easy way out. The least you can do is supply the same fix to that other place that has the same bug. This is not nice. You have identified a deficiency in the generic layer, You know that objects would have the same bug, (because I told you) and you just don't care. I have spent plenty of times slaving over blocks code when changing or fixing generic layer. (And Benny even more then me) And when you will actually send a patch that does exactly the same in two places, which access only generic members, you might see that it might be better to fix it in a single place at the generic layer. NACK. I'm ok with getting lazy like below, but only if you also add the same code to objio_osd.c Sorry, I sent the wrong patch. Trond, please drop this one. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
