On Tue, 20 Sep 2011 14:13:32 +0400 Stanislav Kinsbursky <skinsbursky@xxxxxxxxxxxxx> wrote: > v4: > 1) creation and destruction on rpcbind clients now depends on service program > versions "vs_hidden" flag. > > This patch is required for further RPC layer virtualization, because rpcbind > clients have to be per network namespace. > To achive this, we have to untie network namespace from rpcbind clients sockets. > The idea of this patch set is to make rpcbind clients non-static. I.e. rpcbind > clients will be created during first RPC service creation, and destroyed when > last RPC service is stopped. > With this patch set rpcbind clients can be virtualized easely. > > > The following series consists of: > > --- > > Stanislav Kinsbursky (8): > SUNRPC: introduce helpers for reference counted rpcbind clients > SUNRPC: use rpcbind reference counting helpers > SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure > SUNRPC: setup rpcbind clients if service requires it > SUNRPC: cleanup service destruction > NFSd: call svc rpcbind cleanup explicitly > SUNRPC: remove rpcbind clients creation during service registering > SUNRPC: remove rpcbind clients destruction on module cleanup > > > fs/nfsd/nfssvc.c | 2 + > include/linux/sunrpc/clnt.h | 2 + > include/linux/sunrpc/svc.h | 1 + > net/sunrpc/rpcb_clnt.c | 85 ++++++++++++++++++++++++++++--------------- > net/sunrpc/sunrpc_syms.c | 3 -- > net/sunrpc/svc.c | 48 +++++++++++++++++++++++- > 6 files changed, 105 insertions(+), 36 deletions(-) > Patchset looks good to me. The only remaining thing I think is to set vs_hidden on nfs4_callback_version4, but that patch is orthogonal to this set. Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html