On Fri, 09 Sep 2011 11:02:58 +0100, David Howells <dhowells@xxxxxxxxxx> wrote: > Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> wrote: > > > -static inline int may_create(struct inode *dir, struct dentry *child) > > +static inline int may_create(struct inode *dir, struct dentry *child, int isdir) > > Would it make sense to pass the proposed mode_t instead? That way you can > check for symlinks and other file types too if necessary later. > How about making that change when we need to check for those file types ?. Currently we need to check only if it is a directory or not, and most of the callers and simply use 1, 0, converting it to mode_t would mean we build proper mode values there. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
