On Aug 26, 2011, at 4:52 PM, Bryan Schumaker wrote:
> nfsiostat was failing to find mounted filesystems on recent kernels due
> to changes in the VFS that resulted in a missing "device" tag in the
> /proc/self/mountstats file.
What was the commit ID that changed this formal kernel API? I'd like to see the justification.
> This patch re-adds the "device" tag for NFS
> mount data in /proc/self/mountstats.
The purpose of mountstats is to be an interface that all file systems can use. If we can't add "device" back to all mounts listed in /proc/self/mountstats, it might be better to adjust nfsiostats to cope.
> Signed-off-by: Bryan Schumaker <bjschuma@xxxxxxxxxx>
> ---
> fs/nfs/super.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index b961cea..e6a0317 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -766,8 +766,10 @@ static int nfs_show_devname(struct seq_file *m, struct vfsmount *mnt)
> devname = nfs_path(&dummy, mnt->mnt_root, page, PAGE_SIZE);
> if (IS_ERR(devname))
> err = PTR_ERR(devname);
> - else
> + else {
> + seq_puts(m, "device ");
> seq_escape(m, devname, " \t\n\\");
> + }
> free_page((unsigned long)page);
> return err;
> }
> --
> 1.7.6
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
