Hi, I have moved the error handling inside mds_ops->rpc_release to reuse code as suggested by Boaz. I think we still need to issue the IO even for write because we don't know if current writeback is the last one. So if we re-dirty the pages and this is the last flush (flush at file close), then we don't have a later flusher to writeback the re-dirtied pages. Boaz, please help see if current approach is OK. Thanks. The two cleanup patches (pipe upcall and set_lo_fail) are seperated out of this patchset so they can be merged more easily. Thanks, Tao Peng Tao (3): pNFS: recoalesce when ld write pagelist fails pNFS: recoalesce when ld read pagelist fails pNFS: introduce pnfs private workqueue fs/nfs/blocklayout/blocklayout.c | 17 +++++-- fs/nfs/objlayout/objio_osd.c | 8 +++ fs/nfs/objlayout/objlayout.c | 4 +- fs/nfs/pnfs.c | 92 +++++++++++++++++++++++++++----------- fs/nfs/pnfs.h | 8 +++- fs/nfs/read.c | 13 +++++- fs/nfs/write.c | 25 ++++++++++- 7 files changed, 129 insertions(+), 38 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html