On Thu, Aug 11, 2011 at 06:29:20PM -0700, Boaz Harrosh wrote: > With this patch I'm back to the previous behavior. That is > wait your grace period then continue. Is it true for some reason that the client never sends RECLAIM_COMPLETE? --b. > > --- > NFSD: Remove a wrong check in nfs4_open > > We are already doing the proper grace period checking > farther down in nfs4_open. This check was just checking > nothing and was totally unrelated to the comment about > "RECLAIM_COMPLETE". It was a bug because if an open was > coming before the grace period end, it would then never > pass the condition of not being cl_firststate. > > Boaz > > --- > @@ -295,15 +295,6 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, > if (open->op_create && open->op_claim_type != NFS4_OPEN_CLAIM_NULL) > return nfserr_inval; > > - /* > - * RFC5661 18.51.3 > - * Before RECLAIM_COMPLETE done, server should deny new lock > - */ > - if (nfsd4_has_session(cstate) && > - !cstate->session->se_client->cl_firststate && > - open->op_claim_type != NFS4_OPEN_CLAIM_PREVIOUS) > - return nfserr_grace; > - > if (nfsd4_has_session(cstate)) > copy_clientid(&open->op_clientid, cstate->session); > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
