On 08/11/2011 06:26 AM, Chris Metcalf wrote: > > You can't use a cast with do_div() or you get errors about non-lvalues. > > And the context here is that we want the remainder, not the divided result, > so we'd need a temporary variable anyway if we were going to use a routine > from math64.h, presumably div_u64_rem(). But that's just an inline wrapper > around do_div() anyway, so it's no more efficient, and not obviously any > less "cluttered" in the source code here. The original code author (who > I'm adding belatedly to this email) may have a stronger opinion. > > I'm not the author or maintainer of this code, I just want it to compile > without warning on 32-bit architectures :-) > Still, if you fix it do it properly by using, as you said, div_u64_rem(). It's what needs to be used with u64 types. Thanks Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
