This helper returns true for the IS_SYNC or O_SYNC conditions which are already handled in generic code using generic_write_sync, leading to a double data writeout in both the write and splice_write path. Even worse nfs is using vfs_fsync instead of the range variant used by the generic code, making O_SYNC writes on NFS much heavier than they need to be. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html