Trond Myklebust wrote: On Fri, 2011-07-29 at 11:54 -0400, Jim Rees wrote: > + > +/* We are relying on page lock to serialize this */ > +int is_sector_initialized(struct pnfs_inval_markings *marks, sector_t isect) This either needs a prefix, or it should be declared 'static' Clearly I need to go through the source and systematically catch all of these. Anyone have a good tool for doing so? Otherwise I'll give nm a try. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html