Boaz Harrosh wrote: On 07/27/2011 01:22 PM, Trond Myklebust wrote: > On Wed, 2011-07-27 at 13:05 -0700, Boaz Harrosh wrote: >> On 07/27/2011 11:40 AM, Jim Rees wrote: >>> From: Peng Tao <bergwolf@xxxxxxxxx> >>> >>> Some layout drivers like block will have multiple segments. Generic code >>> should be able to handle it. Layoutcommit takes a list of segments and last >>> write offset is saved at inode level. >>> >>> Signed-off-by: Peng Tao <peng_tao@xxxxxxx> >> >> Trond Hi >> >> Could you please add this patch to the current Merge window? And also include >> >> CC: Stable <stable@xxxxxxxxxxxxxxx> > > Nope. > > Firstly it exacerbates an existing bug in the current code (see my > comments). > > Secondly, it does several things at once (adding multiple segment > handling, fixing last-byte handling in layoutcommit and credential > handling). Which of these features are actually needed for stable? > OK, I agree I thought of that too. My bakethon post had a narrower scope to just the "adding multiple segment handling" & "last-byte handling" (I think let me check) But I thought for simplicity since this patchset was reviewed then, I've tested with this patch and it works good as well. If you are going to break things up, I can test with the minimal patches and report what is need in Stable. (Is anyone working on it?) We may have over-squashed that one for block layout. I can dig up the original patches if necessary, but I'm guessing you probably have them. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
