Re: [PATCH] nfs: don't use d_move in nfs_async_rename_done

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2011-07-18 at 11:26 -0400, Jeff Layton wrote: 
> If the task that initiated the sillyrename ends up being killed by a
> fatal signal, then it will eventually return back to userspace and end
> up releasing the i_mutex. d_move however needs to be done while holding
> the i_mutex.

Umm... Where is this requirement documented? I thought the rename_lock
was there to protect against lookup races etc with d_move.

Besides, NFS already has
nfs_block_sillyrename()/nfs_unblock_sillyrename() to provide further
exclusion between dentry lookups and revalidations and the silly-unlink
code.

Cheers
  Trond

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux