Re: [PATCH 1/6] SQUASHME: pnfs-block: Remove write_begin/end hooks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tao.peng@xxxxxxx wrote:

  > > + * map_block:  map a requested I/0 block (isect) into an offset in the LVM
  > > + * meta block_device
  >
  > What's a "meta block_device"?
  We can remove the *meta* if you don't like the name.

I've been calling this the "mapped device."  It's produced by blkmapd, which
is short for "block map daemon."  In the kernel it's consistently called the
"meta device."  I'm not crazy about the name either but it needs to be
consistent.  Should I change it?

I just noticed too that there are some outdated comments left over from when
the mapping was done in the kernel:

		/* For each device returned in dlist, call GETDEVICEINFO, and
		 * decode the opaque topology encoding to create a flat
		 * volume topology, matching VOLUME_SIMPLE disk signatures
		 * to disks in the visible block disk list.
		 * Construct an LVM meta device from the flat volume topology.
		 */

What's really going on here is the devices are just being added to a list.
The device is constructed later by the daemon.  I will fix this comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux