On Thu, 2011-07-07 at 10:32 -0400, Jeff Layton wrote:
> Commit 0b760113a fixed the client not to loop indefinitely if the
> rpcbind was continually failing. When this occurs though, the rpc_task
> now exits with a status of -EIO. If the tk_status is -EACCES, it seems
> like we should preserve that in this situation.
Why? This isn't the POSIX EACCES error, but a sign that the server is
once again refusing to do business with us: usually that means EIO.
Cheers
Trond
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
> net/sunrpc/clnt.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index 8c91415..77f6c0c 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -1175,8 +1175,10 @@ call_bind_status(struct rpc_task *task)
> status = -EOPNOTSUPP;
> break;
> }
> - if (task->tk_rebind_retry == 0)
> + if (task->tk_rebind_retry == 0) {
> + status = task->tk_status;
> break;
> + }
> task->tk_rebind_retry--;
> rpc_delay(task, 3*HZ);
> goto retry_timeout;
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
