On Thu, 30 Jun 2011 06:58:04 -0400 Steve Dickson <SteveD@xxxxxxxxxx> wrote: > > > On 06/29/2011 07:09 PM, NeilBrown wrote: > > On Wed, 29 Jun 2011 10:28:23 -0400 Steve Dickson <SteveD@xxxxxxxxxx> wrote: > > > >> > >> > >> On 06/28/2011 06:41 AM, Prem Karat wrote: > >>> > >>> Currently souce and destination parameters should be passed as first and > >>> second paramter while using mount.nfs. This patch allows them to be passed > >>> anywhere while mounting. > >>> > >>> Current functionality is > >>> mount.nfs source destn -o <options> > >>> This patch will allow to do this > >>> mount.nfs -o <options> source destn > >>> or > >>> mount.nfs -o <options> source -o <options> destn > >>> > >>> Signed-off-by: Prem Karat <prem.karat@xxxxxxxxxxxxxxxxxx> > >> Committed... > > > > Uhmm... that's unfortunate because the patch is badly broken. > > > > With the patch in place, argv[2] gets destroyed. > > i.e. mount cannot possibly work correctly now. > > > > And that is just the start of the problems. > > > > This patch has clearly never been tested. > Hmm... well this is not true... I have 1.2.4 running > on a number of machines and without a problem... I'm guessing you used --enable-libmount-mount which causes the patched code to not be compiled. So while you did test nfs-utils, I don't think you tested the patch :-( > > But I will looking what you are saying... > Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
