Re: [PATCH 1/1] nfs-utils: Don't hard code source and destination args

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 28, 2011, at 1:59 PM, Luk Claes wrote:

> On 06/28/2011 07:49 PM, Chuck Lever wrote:
>> 
>> On Jun 28, 2011, at 12:59 PM, Prem Karat wrote:
>> 
>>> On 06/28/11 12:02pm, Chuck Lever wrote:
>>>> 
>>>> On Jun 28, 2011, at 6:41 AM, Prem Karat wrote:
>>>> 
>>>>> 
>>>>> Currently souce and destination parameters should be passed as first and 
>>>>> second paramter while using mount.nfs. This patch allows them to be passed 
>>>>> anywhere while mounting.
>>>>> 
>>>>> Current functionality is
>>>>> 	mount.nfs source destn -o <options>
>>>>> This patch will allow to do this
>>>>> 	mount.nfs -o <options> source destn
>>>>> 		or
>>>>> 	mount.nfs -o <options> source -o <options> destn
>>>> 
>>>> Yep, that's clear, but why is this desirable?  mount.nfs should be invoked only by the mount command.  It's not meant to be run by humans.
>>> Bare with me if my understanding is incorrect, however the man page does say that
>>> it can be used as a standalone command with limited functionality.
>> 
>> Yes, it can be used that way, but it rarely is, and that's by design.
>> 
>>> Also it makes sense to use it if a newbie wants to know the nfs specific
>>> options. The mount.nfs command shows a pointer to the correct man page for
>>> nfs specific options.

The mount(8) man page already has a pointer to nfs(5), it looks like.  IMO mount(8) probably shouldn't even mention mount.nfs.

>> I don't understand.  Why would a "newbie" invoke mount.nfs?  Is there a new use case that requires the additional flexibility?
>> 
>> I don't have a specific objection here, but this seems like an arbitrary change.
> 
> When debugging, it's quite handy that one can switch from mount to
> mount.nfs without having to change the order of the arguments.

Do any of the other mount subcommands (eg. mount.fuse, mount.cifs, mount.tmpfs) need this change too?

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux