On Fri, 2011-06-10 at 15:55 -0400, Benny Halevy wrote: > On 2011-06-10 02:32, Sid Moore wrote: > > Hi > > > > I think it might be an error when typing. see the patch below. > > > > > > --- a/fs/nfs/nfs4xdr.c > > +++ b/fs/nfs/nfs4xdr.c > > @@ -1772,7 +1772,7 @@ static void encode_create_session(struct xdr_stream *xdr, > > *p++ = cpu_to_be32(0); /* rdmachannel_attrs */ > > > > /* Back Channel */ > > - *p++ = cpu_to_be32(args->fc_attrs.headerpadsz); /* header > > padding size */ > > + *p++ = cpu_to_be32(args->bc_attrs.headerpadsz); /* header > > padding size */ > > *p++ = cpu_to_be32(args->bc_attrs.max_rqst_sz); /* max req size */ > > *p++ = cpu_to_be32(args->bc_attrs.max_resp_sz); /* max resp size */ > > *p++ = cpu_to_be32(args->bc_attrs.max_resp_sz_cached); /* Max > > resp sz cached */ > > > > -- > > Sid > > -- > > Thanks for spotting this! > Since we don't support header padding yet the following patch > might be more appropriate. > Trond, what do you think? Agreed. If it is unused, then let's ditch it... Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
