On 06/09/2011 07:16 PM, Boaz Harrosh wrote: > On 06/09/2011 03:15 PM, Jim Rees wrote: >> Boaz Harrosh wrote: >> >> Who is going to SQUASH all the SQUASHMEs and re think the all patch >> separation again. To something that makes a more logical progression >> and easier on the review. The way it is now I'm not able to review, >> sorry, I got lost trying to understand which is which. >> >> I'm open to suggestions and happy to do the work. I agree that 88 patches >> is nearly indigestable. However I note that Benny seems to have pulled in >> the entire set so I'm not sure how to proceed at this point. Also this code >> was in Benny's 2.6.38 and only got dropped when the 3.0 merge came along, so >> most of it's already been under review for a year or more. > > Lets start by squashing all the SQUASHMEs into their proper place, that will > get you down to 49. You might notice that it could get hard and it will be > easier to actually take the complete code and re-divide it to patches, a fresh. > crafted more less on the old division strategy. > > It's what Fred did at the final files submission. And it is what I did more > or less with the objects final submission. But you might find that for you > it is easier to rebase and squash the patches together after you re-order > them. It's your call and you will not know before you experiment a little. > I can show you some techniques I use on both these paths. > (Let's meet in B next week) > > Then you should do a second pass to see that each patch is compile-able and > makes sense and maybe also reorder the introduction of the generic parts > close to where they are used in the pachset progression. Again like we did > for files and objects. > > Thanks > Boaz Ho and I forgot, once you do all that we might want to revisit all these patches that have HACK in their title. I guess Fred can help with some of these Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
