Re: [PATCH 87/88] Add configurable prefetch size for layoutget

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Jim and Benny,

On Thu, Jun 9, 2011 at 9:58 PM, Jim Rees <rees@xxxxxxxxx> wrote:
> Benny Halevy wrote:
>
> Â> My understanding is that layoutget specifies a min and max, and the server
>
> ÂThere's a min. ÂWhat do you consider the max?
> ÂWhatever gets into csa_fore_chan_attrs.ca_maxresponsesize?
>
> The spec doesn't say max, it says "desired." ÂI guess I assumed the server
> wouldn't normally return more than desired.
In fact server is returning "desired" length. The problem is that we
call pnfs_update_layout in nfs_write_begin, and it will end up setting
both minlength and length to page size. There is no space for client
to collapse layoutget range in nfs_write_begin.

>
> 18.43.3. ÂDESCRIPTION
> ...
>
> Â The LAYOUTGET operation returns layout information for the specified
> Â byte-range: a layout. ÂThe client actually specifies two ranges, both
> Â starting at the offset in the loga_offset field. ÂThe first range is
> Â between loga_offset and loga_offset + loga_length - 1 inclusive.
> Â This range indicates the desired range the client wants the layout to
> Â cover. ÂThe second range is between loga_offset and loga_offset +
> Â loga_minlength - 1 inclusive. ÂThis range indicates the required
> Â range the client needs the layout to cover. ÂThus, loga_minlength
> Â MUST be less than or equal to loga_length.
>



-- 
Thanks,
-Bergwolf
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux