On Thu, 2011-05-26 at 16:19 +0300, Boaz Harrosh wrote: > Every thing was ready, in pnfs_roc(). The segments released > and the LO state blocked til after the close is done. All that > is needed is to send the actual layoutreturn synchronously. Why would we want to do this? Return-on-close was initially considered useful only for debugging. At the interim IETF meeting in Sunnyvale, we also discussed the case where the forgetful client has forgotten the layout: in this case the server may decide to forget the layout too. There is no controversy in doing this, since both the client and the server know that any outstanding layout is supposed to be returned (and if there is a problem, then the server always has the option of sending a CB_LAYOUTRECALL). Adding a synchronous call to close is in any case a bug since close can on occasion be sent in situations where we don't allow sleeping. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
