On 05/23/2011 04:44 PM, Benny Halevy wrote: > On 2011-05-23 07:52, Boaz Harrosh wrote: >> On 05/23/2011 02:58 AM, Benny Halevy wrote: >>> Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxx> >> >> Benny sorry but NACK on the global device cache for now >> >> This is to late at this stage. We have decided that first imp will >> use the private cache and we'll postpone these cleanups for later. >> >> All other code was well tested for years, all this is new code, and > > The file layout is upstream and better be harnessed for other layout > drivers as well. If it's inferior to the current objects layout cache > we should fix and improve the former rather than introducing a new > implementation. > >> new behaviour that we will not have time to test. I do not like the > > Ideally, the should already be fully tested, but last minute review- > related changes will always require further testing that needs to be > taken place during the -rc cycle. The whole point of having rc's is > to stabilize the merged code to a point it can be released as a stable > release. > >> code as it is. Because currently it will release the device on layout_return. >> Where is the cache? There is much more work to do here! >> > > Like I said, if there are bugs we should fix them rather introducing > alternative code that does the same thing. > >> We already said not to do this in this merge why the change of heart? > > We discussed that again on Thursday's conference call which you did not > attend. I decided to take a stab at it to see how a unified cache would > look like and I rather like the outcome.. > > Benny > As I suspected this is crashing all over the place. Finally I was able to rebase a server on your latest code. (And find out what I was missing). I'm fighting with it for two hours now. And I don't see the end of it. Again I'm not at all against this work. I have my own version of this in my tree. Only against the timing. Your latest code cannot go in now. It is to new! What do you want to do now? Postpone pnfs-objects to next Kernel. Or put in good solid code that was tested and worked for a long time. I'm not sleeping nights, have worked all through both weekends. Now it is for nothing. Thanks alot! Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
