On May 18, 2011, at 4:29 PM, Weston Andros Adamson wrote: > Some clarification: > > If ipv6.ko can't be found, this patch will still try to connect to the v6 address, fail (EIO) and revert to the MDS. > > In order to properly handle this, we need to handle errors on connect and try another multipath address. > I feel that this is really part of the other "half" of the multipath work (actually using more than one address), which we will get to very soon and should be treated as a separate patch. Unless there are objections... Sounds like a plan. My only concern is that your proposed code fails gracefully in the case that ipv6.ko cannot be loaded. Crashing was a typical failure mode for this case while IPv6 support was being developed. > -dros > > On May 18, 2011, at 4:19 PM, Weston Andros Adamson wrote: > >> Yeah, that should work too. Like other parts of fs/nfs/, I relied on rpc_pton() to allow or disallow parsing ipv6 addresses. >> >> -dros >> >> On May 18, 2011, at 4:11 PM, Chuck Lever wrote: >> >>> >>> On May 18, 2011, at 3:57 PM, Weston Andros Adamson wrote: >>> >>>> These two patches add support for IPv6 dataserver connectivity and >>>> parsing all multipath addresses. >>>> >>>> IPv6: basically same patch as before: >>>> - no longer calls kzalloc() while holding spinlock >>>> - i verified that everything works as expected when CONFIG_IPV6 is not defined >>> >>> You'll also need to worry about when IPv6 is built in a kernel module, but ipv6.ko cannot be loaded. >>> >>> -- >>> Chuck Lever >>> chuck[dot]lever[at]oracle[dot]com >>> >>> >>> >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
