Re: [PATCH] nfs: don't lose MS_SYNCHRONOUS on remount of noac mount

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Apr 2011 14:01:47 -0400
Trond Myklebust <Trond.Myklebust@xxxxxxxxxx> wrote:

> On Wed, 2011-04-27 at 11:49 -0400, Jeff Layton wrote:
> > On a remount, the VFS layer will clear the MS_SYNCHRONOUS bit on the
> > assumption that the flags on the mount syscall will have it set if the
> > remounted fs is supposed to keep it.
> > 
> > In the case of "noac" though, MS_SYNCHRONOUS is implied. A remount of
> > such a mount will lose the MS_SYNCHRONOUS flag since "sync" isn't part
> > of the mount options.
> > 
> > Reported-by: Max Matveev <makc@xxxxxxxxxx>
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> 
> Should this be 'Cc: stable@xxxxxxxxxx'?

Yes, it wouldn't hurt. Not an extremely critical bug, but it's a
fairly straightforward fix. Can you add that, or would you rather I
resend?

Thanks,
-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux