Re: [PATCH 1/1] nfsd v4.1 lOCKT clientid field must be ignored

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 22, 2011 at 12:45:59PM -0400, andros@xxxxxxxxxx wrote:
> From: Andy Adamson <andros@xxxxxxxxxx>
> 
> RFC 5661 Section 18.11.3
> 
>    The clientid field of the owner MAY be set to any value by the client
>    and MUST be ignored by the server.  The reason the server MUST ignore
>    the clientid field is that the server MUST derive the client ID from
>    the session ID from the SEQUENCE operation of the COMPOUND request.

I thought I'd checked the network and determined the failure prevented
the client from even sending a request--but I guess not!  Thanks for
tracking this down, applied.--b.

> 
> Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> ---
>  fs/nfsd/nfs4xdr.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index abdd42d..eb234df 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -591,8 +591,6 @@ nfsd4_decode_lockt(struct nfsd4_compoundargs *argp, struct nfsd4_lockt *lockt)
>  	READ_BUF(lockt->lt_owner.len);
>  	READMEM(lockt->lt_owner.data, lockt->lt_owner.len);
>  
> -	if (argp->minorversion && !zero_clientid(&lockt->lt_clientid))
> -		return nfserr_inval;
>  	DECODE_TAIL;
>  }
>  
> -- 
> 1.7.2.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux