On 04/04/2011 10:46 PM, Serge E. Hallyn wrote: > Quoting Rob Landley (rlandley@xxxxxxxxxxxxx): >> From: Rob Landley <rlandley@xxxxxxxxxxxxx> >> >> The auth_unix cache needs to check network namespace when comparing >> addresses. Add field to struct ip_map and extra argument to >> __ip_map_lookup() so it has the information to do so, and add test. >> >> Signed-off-by: Rob Landley <rlandley@xxxxxxxxxxxxx> >> --- >> >> net/sunrpc/svcauth_unix.c | 21 ++++++++++++++------- >> 1 file changed, 14 insertions(+), 7 deletions(-) >> >> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c >> index 30916b0..63a2fa7 100644 >> --- a/net/sunrpc/svcauth_unix.c >> +++ b/net/sunrpc/svcauth_unix.c code code code >> @@ -142,6 +145,7 @@ static void ip_map_init(struct cache_head *cnew, struct cache_head *citem) >> struct ip_map *item = container_of(citem, struct ip_map, h); >> >> strcpy(new->m_class, item->m_class); >> + new->m_net = item->m_net; > > Does this need to take a reference? Or is there no way for an > entry to outlive its netns? It sort of looks like > svcauth_unix_info_release will ensure that doesn't happen, but > I'm not convinced because other parts of the kernel can get > to ip_map_init through the struct cache_detail. When I wrote this I thought the transport's get_net() and put_net() would pin it, but after re-reading, the sunrpc code is disgustingly convoluted enough that I can't easily reconstruct my earlier reasoning. I'll add a get_net() and put_net() just to not have to worry about it. Thanks, Rob -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
