Re: [PATCH] nfs4: Fix memory corruption due to not expected FS_LOCATIONS v3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2011-03-22 at 17:46 -0400, Trond Myklebust wrote:

> Why are you limiting this to fs_locations?

Sorry, I haven't seen any other attribute that can cause memory
corruption.

>  As I believe I said earlier,
> any attribute that we didn't explicitly request is an error and can
> cause corruption in the client.

There are checks on each decode attr function. For instance,
decode_attr_filehandle:

 	if (unlikely(bitmap[0] & (FATTR4_WORD0_FILEHANDLE - 1U)))
		return -EIO;

So any non handled attribute raise EIO error.

> 
> If we're going to fix this, we should fix all potential occurrences once
> and for all.

Yes, I agree. Could you direct that I missed ?

> 

-- 
Thanks,
Vitaliy Gusev

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux