On Tue, Mar 15, 2011 at 11:06:38AM +0800, Mi Jinlong wrote: > > > J. Bruce Fields: > > On Wed, Mar 02, 2011 at 02:36:15PM +0800, Mi Jinlong wrote: > >> Signed-off-by: Mi Jinlong <mijinlong@xxxxxxxxxxxxxx> > > > > I'm getting failures I don't understand on these reclaim complete tests > > too. > > Maybe there are some problem I have missing. > > If testing reclaim-complete, we should restart server's NFS service. > I think those tests about reclaim-complete need some fix. Probably so. Also: > >> + oseqid = res.resarray[2].stateid > >> + cfh = res.resarray[3].object This has the same problem as SEQ14, I suspect. In general I'm nervous about grabbing results directly out of the resarray. We shouldn't have to know so much about the structure of a compound that some other part of the code constructed. --b. > >> + owner = open_owner4(0, "My Open Owner") > >> + otlowner = open_to_lock_owner4(0, oseqid, 0, owner) > >> + lowner = locker4(TRUE, otlowner) > >> + > >> + res = sess.compound([op.putfh(cfh), op.lock(READ_LT, FALSE, 0, 1, lowner)]) > >> + check(res, NFS4ERR_NO_GRACE) > >> -- > >> 1.7.4.1 > >> > >> > >> > > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
