Re: [PATCH] nfs: fix compilation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 6, 2011 at 8:01 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> On Wed, Â2 Mar 2011 18:19:37 -0500 bookjovi@xxxxxxxxx wrote:
>
>> From: Jovi Zhang <bookjovi@xxxxxxxxx>
>>
>> this commit fix compilation warning as following:
>> linux-2.6/fs/nfs/nfs4proc.c:3265: warning: comparison of distinct pointer types lacks a cast
>>
>> Signed-off-by: Jovi Zhang <bookjovi@xxxxxxxxx>
>> ---
>> Âfs/nfs/nfs4proc.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
>> index 1ff76ac..c7eb4ee 100644
>> --- a/fs/nfs/nfs4proc.c
>> +++ b/fs/nfs/nfs4proc.c
>> @@ -3262,7 +3262,7 @@ static int buf_to_pages_noslab(const void *buf, size_t buflen,
>> Â Â Â spages = pages;
>>
>> Â Â Â do {
>> - Â Â Â Â Â Â len = min(PAGE_CACHE_SIZE, buflen);
>> + Â Â Â Â Â Â len = min((size_t)PAGE_CACHE_SIZE, buflen);
>> Â Â Â Â Â Â Â newpage = alloc_page(GFP_KERNEL);
>>
>> Â Â Â Â Â Â Â if (newpage == NULL)
>> --
>
> or use
> Â Â Â Âlen = min_t(size_t, PAGE_SIZE_CACHE, buflen);
>
That's good, Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux