On Fri, Mar 04, 2011 at 03:30:59PM -0500, Jeff Layton wrote: > On Fri, 4 Mar 2011 15:07:03 -0500 > "J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote: > > In this case, we're not kfree()'ing until we've gotten an rpc reply > > back. But in theory perhaps there could be cases where the server's > > gotten the data and we've seen the reply but the tcp layer still thinks > > it needs to retransmit something? I don't think we'd care if the data > > was still correct in that case, but it could be an information leak if > > nothing else. > > There's also timeouts + soft mounts to consider. We may send the data > on the socket, which gets buffered up and then the caller goes to sleep > waiting for a reply. If that never comes (server crashed or something), > then we can return an error back up to the VFS layer if it's a soft > mount. Meanwhile, the kernel is still trying to send the data on the > socket... Good point, I forgot about that. Thanks to everyone for setting me straight! --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
