Re: [PATCH 3/2] mount: Allow 'port=0' to be a valid port value.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steve-

On Mar 3, 2011, at 3:04 PM, Steve Dickson wrote:

> With the new util-linux, /etc/mtab is now is symbolically linked
> to /proc/mounts. In /proc/mounts, the 'port=0' exits which causes
> the umount.nfs to error out with the following error:
>   umount.nfs: invalid value for 'port=' option
> 
> Setting port=0 is a valid value. It just means go out and query
> remote rpcbind to get the correct port.
> 
> Signed-off-by: Steve Dickson <steved@xxxxxxxxxx>

Why are you signing off on this?  I sent you this patch weeks ago.  (In fact my version of the patch also fixes this problem in nfs_mount_port() as well).

> ---
> utils/mount/network.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index 8049c1a..88ab222 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -1346,7 +1346,7 @@ nfs_nfs_port(struct mount_options *options, unsigned long *port)
> 	case PO_NOT_FOUND:
> 		break;
> 	case PO_FOUND:
> -		if (tmp >= 1 && tmp <= 65535) {
> +		if (tmp >= 0 && tmp <= 65535) {
> 			*port = tmp;
> 			return 1;
> 		}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com




--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux